chia7712 commented on code in PR #20375:
URL: https://github.com/apache/kafka/pull/20375#discussion_r2296841359
##########
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##########
@@ -11668,4 +11668,26 @@ private static StreamsGroupDescribeResponseData
makeFullStreamsGroupDescribeResp
.setAssignmentEpoch(1));
return data;
}
+
+ @Test
Review Comment:
Could you please add `@Timeout(30)` to this unit test?
##########
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##########
@@ -11668,4 +11668,26 @@ private static StreamsGroupDescribeResponseData
makeFullStreamsGroupDescribeResp
.setAssignmentEpoch(1));
return data;
}
+
+ @Test
+ public void testDescribeTopicsTimeoutWhenNoBrokerResponds() throws
Exception {
+ try (AdminClientUnitTestEnv env = new AdminClientUnitTestEnv(
+ mockCluster(1, 0),
+ AdminClientConfig.RETRIES_CONFIG, "0",
+ AdminClientConfig.REQUEST_TIMEOUT_MS_CONFIG, "30000")) {
+ env.kafkaClient().setNodeApiVersions(NodeApiVersions.create());
+
+ // Not using prepareResponse is equivalent to "no brokers respond".
+ long start = System.currentTimeMillis();
+ DescribeTopicsResult result =
env.adminClient().describeTopics(Collections.singletonList("test-topic"), new
DescribeTopicsOptions().timeoutMs(200));
+ Map<String, KafkaFuture<TopicDescription>> topicDescriptionMap =
result.topicNameValues();
+ KafkaFuture<TopicDescription> topicDescription =
topicDescriptionMap.get("test-topic");
+ ExecutionException exception =
assertThrows(ExecutionException.class, () -> topicDescription.get());
Review Comment:
```
assertThrows(ExecutionException.class, topicDescription::get);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
