kirktrue commented on code in PR #20324:
URL: https://github.com/apache/kafka/pull/20324#discussion_r2279421782
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java:
##########
@@ -243,8 +237,11 @@ public CompletableFuture<Boolean>
updateFetchPositions(long deadlineMs) {
if (subscriptionState.hasAllFetchPositions()) {
// All positions are already available
+
commitOffsetsSharedState.setSubscriptionHasAllFetchPositions(true);
Review Comment:
@frankvicky—Agreed. This is complexity that I wish we didn't need to
introduce. Unfortunately, coordinating events between the application and
background thread are adding substantial CPU load overhead. The process of
scheduling the synchronization is very much a bottleneck.
However, `CommitOffsetsSharedState` is _not_ an event specifically for the
purpose that we can then avoid signaling, synchronization, or any other
inter-thread communication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
