shashankhs11 commented on code in PR #20329:
URL: https://github.com/apache/kafka/pull/20329#discussion_r2279054301
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -492,54 +491,60 @@ <h4><a class="toc-backref"
href="#id45">num.standby.replicas</a><a class="header
The default of <code>-1</code> (meaning: use broker default
replication factor) requires broker version 2.4 or newer.</td>
<td><code class="docutils literal"><span
class="pre">-1</span></code></td>
</tr>
- <tr class="row-odd"><td>retry.backoff.ms</td>
+ <tr class="row-odd"><td>repartition.purge.interval.ms</td>
+ <td>Low</td>
+ <td colspan="2">The frequency in milliseconds with which to delete
fully consumed records from repartition topics. Purging will occur after at
least this value since the last purge, but may be delayed until later.
+ (Note, unlike <code class="docutils literal"><span
class="pre">commit.interval.ms</span></code>, the default for this value
remains unchanged when <code class="docutils literal"><span
class="pre">processing.guarantee</span></code> is set to <code class="docutils
literal"><span class="pre">exactly_once_v2</span></code>)</td>
Review Comment:
I am a little confused on what you mean by "highlight"
1. I decided to include this configuration because it can be tuned by the
users. It was introduced in version `3.2.0` via
[KIP-811](https://cwiki.apache.org/confluence/display/KAFKA/KIP-811%3A+Add+config+repartition.purge.interval.ms+to+Kafka+Streams)
but missed to add in docs?
2. Or did you mean only this last line?
> (Note, unlike `commit.interval.ms`, the default for this value remains
unchanged when `processing.guarantee` is set to `exactly_once_v2`).
I used to same description mentioned in the KIP. I think that this line
avoids a confusion (if exists) since it is related to `commit.interval.ms`. I
am happy to remove this if you think otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
