mjsax commented on code in PR #18800:
URL: https://github.com/apache/kafka/pull/18800#discussion_r2162788483


##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##########
@@ -1307,6 +1295,7 @@ public <KOut, VOut> KStream<KOut, VOut> process(
             name,
             new ProcessorParameters<>(processorSupplier, name),
             stateStoreNames);
+        processNode.requireRepartitionAlways();

Review Comment:
   Why "always"? A `process()` step is key-changing operation, so 
repartitioning might be required downstream, but only if a key-dependent 
operator like groupByKey() or join() follows.
   
   So should we just call `processNode.setKeyChangingOperation(true)` instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to