Yunyung commented on code in PR #20159:
URL: https://github.com/apache/kafka/pull/20159#discussion_r2267098807
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionalRequestResult.java:
##########
@@ -48,15 +50,19 @@ public void done() {
}
public void await() {
- this.await(Long.MAX_VALUE, TimeUnit.MILLISECONDS);
+ this.await(Long.MAX_VALUE, TimeUnit.MILLISECONDS, () -> new
KafkaException("Unknown reason."));
Review Comment:
Hi, these two lines are exactly the same for your current change, right?
this.await(Long.MAX_VALUE, TimeUnit.MILLISECONDS); (This will call public
void await(long timeout, TimeUnit unit))
this.await(Long.MAX_VALUE, TimeUnit.MILLISECONDS, () -> new
KafkaException("Unknown reason."));
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
