kevin-wu24 commented on code in PR #19589:
URL: https://github.com/apache/kafka/pull/19589#discussion_r2254730246
##########
raft/src/main/java/org/apache/kafka/raft/RaftUtil.java:
##########
@@ -524,14 +526,16 @@ public static AddRaftVoterRequestData addVoterRequest(
String clusterId,
int timeoutMs,
ReplicaKey voter,
- Endpoints listeners
+ Endpoints listeners,
+ boolean ackWhenCommitted
Review Comment:
> "Ack when committed" should always be false
I don't think this is true, since there are callers of this method in
`KafkaRaftClientReconfigTest` that do test sending an `AddVoterRequest` with
`ackWhenCommitted == true` since it is testing the leader state when receiving
this RPC. I agree that `KafkaRaftClient` should always call this method with
`false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
