harmadasg commented on PR #20128: URL: https://github.com/apache/kafka/pull/20128#issuecomment-3139075388
> @harmadasg thanks for the reference to [KAFKA-9267](https://issues.apache.org/jira/browse/KAFKA-9267), it strengthens the point that a default `null` could cause issues elsewhere. I think that users who'd upgrade to fix this NPE during a migration is slim and the workaround is easy, so I'd be in favor of changing the default to an empty array. @viktorsomogyi as discussed I only skipped processing /migration in `ZkSecurityMigrator ` as `zkClient.makeSurePersistentPathExists` is used in many places and I wanted to reduce the scope of my change. Also probably the empty array would still result in errors when trying to decode against a specific znode structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
