chia7712 commented on code in PR #20237:
URL: https://github.com/apache/kafka/pull/20237#discussion_r2243367842
##########
docs/ops.html:
##########
@@ -4499,8 +4499,15 @@ <h4 class="anchor-heading"><a
id="eligible_leader_replicas_upgrade" class="ancho
<h4 class="anchor-heading"><a id="eligible_leader_replicas_tool"
class="anchor-link"></a><a href="#eligible_leader_replicas_tool">Tool</a></h4>
<p>The ELR fields can be checked through the API DescribeTopicPartitions.
The admin client can fetch the ELR info by describing the topics.
- Also note that, if <code>min.insync.replicas</code> is updated for a
topic, the ELR field will be cleaned. If cluster default min ISR is updated,
- all the ELR fields will be cleaned.</p>
+ Note that when the ELR feature is enabled:
+ <ul>
+ <li>The override of <code>min.insync.replicas</code> in broker-level
will be removed.</li>
+ <li>The alter of <code>min.insync.replicas</code> config in broker-level
is not allowed.</li>
+ <li>The removal of <code>min.insync.replicas</code> config in
cluster-level is not allowed.</li>
+ <li>If <code>min.insync.replicas</code> is updated for a topic, the ELR
field will be cleaned.</li>
+ <li>If the cluster default <code>min.insync.replicas</code> is updated,
all the ELR fields will be cleaned.</li>
+ </ul>
+ </p>
Review Comment:
this syntax is illegal. Please take a look at following change.
```
<p>The ELR fields can be checked through the API DescribeTopicPartitions.
The admin client can fetch the ELR info by describing the topics.</p>
<p>Note that when the ELR feature is enabled:</p>
<ul>
<li>The override of <code>min.insync.replicas</code> in broker-level
will be removed.</li>
<li>The alter of <code>min.insync.replicas</code> config in broker-level
is not allowed.</li>
<li>The removal of <code>min.insync.replicas</code> config in
cluster-level is not allowed.</li>
<li>If <code>min.insync.replicas</code> is updated for a topic, the ELR
field will be cleaned.</li>
<li>If the cluster default <code>min.insync.replicas</code> is updated,
all the ELR fields will be cleaned.</li>
</ul>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
