ravikalla commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2233214833
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java:
##########
@@ -2998,15 +2993,6 @@ private void
verifyVersionedTaskConverterFromWorker(String converterClassConfig,
verify(plugins).newConverter(any(WorkerConfig.class),
eq(converterClassConfig), eq(converterVersionConfig));
}
- private void mockTaskHeaderConverter(ClassLoaderUsage classLoaderUsage,
HeaderConverter returning) {
Review Comment:
For this specific case, I'm satisfied with removing these unused test
utilities. However, it would be helpful to add a note in the PR description
listing what was removed, so reviewers can verify nothing critical was deleted.
Also, consider running this cleanup as a separate PR in the future to make
reviews easier.
Regarding fields - yes, please apply the same approach consistently. Remove
unused fields as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
