apoorvmittal10 commented on code in PR #20175:
URL: https://github.com/apache/kafka/pull/20175#discussion_r2228240884
##########
server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java:
##########
@@ -237,6 +237,11 @@ public PersisterStateManagerHandler(
this.onCompleteCallback = response -> {
}; // noop
partitionKey = SharePartitionKey.getInstance(groupId, topicId,
partition);
+ String canonicalName = getClass().getCanonicalName();
+ if (canonicalName == null) {
+ canonicalName = getClass().getName();
+ }
+ log = LoggerFactory.getLogger(canonicalName);
Review Comment:
nit: probaly can do later as well. Becuase now it's not always the canonical
name in the variable.
```suggestion
String name = getClass().getCanonicalName();
if (name == null) {
name = getClass().getName();
}
log = LoggerFactory.getLogger(name);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
