kamalcph commented on code in PR #20218:
URL: https://github.com/apache/kafka/pull/20218#discussion_r2226092656
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##########
@@ -973,6 +973,9 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
segmentIdsBeingCopied.add(segmentId);
try {
copyLogSegment(log,
candidateLogSegment.logSegment, segmentId,
candidateLogSegment.nextSegmentOffset);
+ } catch (RemoteStorageException e) {
Review Comment:
the `copyLogSegment` can throw InterruptedException, ExecutionException,
RemoteStorageException, IOException, and
CustomMetadataSizeLimitExceededException.
can we move the `recordLagStats` to the outer catch-block instead to handle
CustomMetadataSizeLimitExceededException / InterruptedException /
RetriableException / Exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
