m1a2st commented on code in PR #20214:
URL: https://github.com/apache/kafka/pull/20214#discussion_r2222434730
##########
trogdor/src/main/java/org/apache/kafka/trogdor/coordinator/CoordinatorClient.java:
##########
@@ -472,7 +471,7 @@ static String prettyPrintTasksResponse(TasksResponse
response, ZoneOffset zoneOf
}
List<List<String>> lines = new ArrayList<>();
List<String> header = new ArrayList<>(
- Arrays.asList("ID", "TYPE", "STATE", "INFO"));
+ List.of("ID", "TYPE", "STATE", "INFO"));
Review Comment:
```suggestion
List<String> header = List.of("ID", "TYPE", "STATE", "INFO");
```
##########
trogdor/src/test/java/org/apache/kafka/trogdor/workload/PayloadGeneratorTest.java:
##########
@@ -180,8 +180,8 @@ public void testRandomComponentPayloadGenerator() {
RandomComponent sequentialConfig2 = new RandomComponent(25,
sequentialGenerator);
RandomComponent nullConfig2 = new RandomComponent(25, nullGenerator);
- List<RandomComponent> components3 = new
ArrayList<>(Arrays.asList(sequentialConfig2, uniformConfig2, nullConfig));
- List<RandomComponent> components4 = new
ArrayList<>(Arrays.asList(uniformConfig2, sequentialConfig2, constantConfig,
nullConfig2));
+ List<RandomComponent> components3 = new
ArrayList<>(List.of(sequentialConfig2, uniformConfig2, nullConfig));
Review Comment:
ditto
##########
trogdor/src/test/java/org/apache/kafka/trogdor/workload/PayloadGeneratorTest.java:
##########
@@ -200,8 +200,8 @@ public void testRandomComponentPayloadGeneratorErrors() {
new ConstantPayloadGenerator(4, new byte[0]);
RandomComponent constantConfig = new RandomComponent(-25,
constantGenerator);
- List<RandomComponent> components1 = new
ArrayList<>(Arrays.asList(nullConfig, uniformConfig));
- List<RandomComponent> components2 = new ArrayList<>(Arrays.asList(
+ List<RandomComponent> components1 = new
ArrayList<>(List.of(nullConfig, uniformConfig));
Review Comment:
ditto
##########
trogdor/src/test/java/org/apache/kafka/trogdor/workload/PayloadGeneratorTest.java:
##########
@@ -146,8 +146,8 @@ public void testRandomComponentPayloadGenerator() {
new ConstantPayloadGenerator(4, new byte[0]);
RandomComponent constantConfig = new RandomComponent(25,
constantGenerator);
- List<RandomComponent> components1 = new
ArrayList<>(Arrays.asList(nullConfig, uniformConfig));
- List<RandomComponent> components2 = new
ArrayList<>(Arrays.asList(sequentialConfig, constantConfig));
+ List<RandomComponent> components1 = new
ArrayList<>(List.of(nullConfig, uniformConfig));
+ List<RandomComponent> components2 = new
ArrayList<>(List.of(sequentialConfig, constantConfig));
Review Comment:
```suggestion
List<RandomComponent> components1 = List.of(nullConfig,
uniformConfig);
List<RandomComponent> components2 = List.of(sequentialConfig,
constantConfig);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
