adixitconfluent commented on code in PR #20207:
URL: https://github.com/apache/kafka/pull/20207#discussion_r2218807394
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -599,7 +598,7 @@ public long nextFetchOffset() {
lock.writeLock().lock();
try {
// When none of the records in the cachedState are in the
AVAILABLE state, findNextFetchOffset will be false
- if (!findNextFetchOffset.get()) {
+ if (!findNextFetchOffset) {
Review Comment:
nit: shouldn't this be `!findNextFetchOffset()`, although there is a write
lock above, but just trying to think about code consistency that
findNextFetchOffset variable is accessible through functions only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
