ijuma commented on code in PR #19762:
URL: https://github.com/apache/kafka/pull/19762#discussion_r2214892949
##########
checkstyle/import-control.xml:
##########
@@ -486,6 +486,7 @@
<allow class="org.apache.kafka.common.compress.Compression"
exact-match="true" />
<allow pkg="org.apache.kafka.common.config" />
<allow pkg="org.apache.kafka.common.feature" />
+ <allow pkg="org.apache.kafka.common.internals" />
Review Comment:
`internals` simply means it should not be used outside the `kafka` repo.
This is more explicit than the uncommon "check the javadoc" to check if the
class is public or internal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
