AndrewJSchofield commented on code in PR #20148:
URL: https://github.com/apache/kafka/pull/20148#discussion_r2200382575
##########
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/ClusterInstance.java:
##########
@@ -178,12 +179,16 @@ default <K, V> ShareConsumer<K, V> shareConsumer() {
}
default <K, V> ShareConsumer<K, V> shareConsumer(Map<String, Object>
configs) {
+ return new KafkaShareConsumer<>(configs, null, null);
+ }
+
+ default <K, V> ShareConsumer<K, V> shareConsumer(Map<String, Object>
configs, Deserializer<K> keyDeserializer, Deserializer<V> valueDeserializer) {
Map<String, Object> props = new HashMap<>(configs);
props.putIfAbsent(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG,
ByteArrayDeserializer.class.getName());
Review Comment:
If you're providing instances of the deserializers, I don't think you should
be setting the class names in the config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
