ahuang98 commented on code in PR #20136:
URL: https://github.com/apache/kafka/pull/20136#discussion_r2198753693
##########
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##########
@@ -376,6 +376,8 @@ Found problem:
val availableDirs = Seq(TestUtils.tempDir())
val properties = new Properties()
properties.putAll(defaultStaticQuorumProperties)
+ properties.remove("controller.quorum.voters")
+ properties.put("controller.quorum.bootstrap.servers", "localhost:9093")
Review Comment:
any reason we can't create one version for the broker? or just define all
the properties from scratch given there are only 4. feels funny that we are
doing a put(staticProperties) then replacing the property that makes it static
in the first place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
