gaurav-narula commented on code in PR #20106:
URL: https://github.com/apache/kafka/pull/20106#discussion_r2190985880
##########
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##########
@@ -166,12 +166,12 @@ class ReplicaFetcherThread(name: String,
val partition = replicaMgr.getPartitionOrException(tp)
val log = partition.localLogOrException
- partition.truncateTo(offsetTruncationState.offset, isFuture = false)
-
if (offsetTruncationState.offset < log.highWatermark)
Review Comment:
Thanks for the feedback! I've moved the log inside `UnifiedLog#truncateTo`.
Although users might be able to disambiguate between the two cases using the
thread name (`ReplicaAlterLogDirsThread` vs `ReplicaFetcherThread`), I felt
it's perhaps better to disambiguate between a future/non-future replica in the
log statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
