AndrewJSchofield commented on code in PR #20101:
URL: https://github.com/apache/kafka/pull/20101#discussion_r2184719024
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2692,7 +2690,27 @@ private boolean initializedAssignmentPending(ShareGroup
group) {
}
}
- return !initializedTps.equals(currentAssigned);
+ Set<String> subscribedTopicNames =
group.subscribedTopicNames().keySet();
Review Comment:
Just added unit tests which verify that this method returns the expected
value in all of the interesting cases. I suggest an integration test which
verifies that the epoch does not increase continuously would be a good
candidate for a future task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
