m1a2st commented on code in PR #20087:
URL: https://github.com/apache/kafka/pull/20087#discussion_r2180482693
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/LogValidatorTest.java:
##########
@@ -545,12 +545,12 @@ public void checkCompressed(byte magic) {
RequestLocal.withThreadConfinedCaching().bufferSupplier()
);
- MemoryRecords validatedRecords = validatedResults.validatedRecords;
+ MemoryRecords validatedRecords = validatedResults.validatedRecords();
int i = 0;
for (RecordBatch batch : validatedRecords.batches()) {
assertTrue(batch.isValid());
- assertEquals(batch.timestampType(), TimestampType.CREATE_TIME);
+ assertEquals(TimestampType.CREATE_TIME, batch.timestampType());
maybeCheckBaseTimestamp(timestampSeq.get(0), batch);
assertEquals(batch.maxTimestamp(), batch.maxTimestamp());
Review Comment:
I think there are the same issue at L365, L1811, We could update the actual
value to
`TestUtils.toList(batch).stream().map(Record::timestamp).max(Long::compare).get()`,
the root cause is https://github.com/apache/kafka/pull/16167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
