Forest0923 commented on PR #19961:
URL: https://github.com/apache/kafka/pull/19961#issuecomment-3026252567

   Sorry, my earlier comment about `truncateToEntries()` was incorrect—please 
disregard it.
   Also, I found that the lock helper was implemented incorrectly:
   
   The Supplier's actual action was executed outside the lock.
   
   ```java
   protected final <T> T inRemapReadLock(Supplier<T> action) {
       return LockUtils.inLock(remapLock.readLock(), () -> action).get();
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to