squah-confluent commented on code in PR #20055:
URL: https://github.com/apache/kafka/pull/20055#discussion_r2174221211
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/CurrentAssignmentBuilder.java:
##########
@@ -139,7 +178,7 @@ public ConsumerGroupMember build() {
member.assignedPartitions()
);
} else {
- return member;
+ return
computeCurrentAssignment(member.assignedPartitions());
Review Comment:
I moved the test and added a few more test cases to cover it.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/CurrentAssignmentBuilder.java:
##########
@@ -139,7 +178,7 @@ public ConsumerGroupMember build() {
member.assignedPartitions()
);
} else {
- return member;
+ return
computeCurrentAssignment(member.assignedPartitions());
Review Comment:
I moved the check and added a few more test cases to cover it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
