appchemist commented on code in PR #18800:
URL: https://github.com/apache/kafka/pull/18800#discussion_r2173645733
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GraphNode.java:
##########
@@ -93,6 +98,14 @@ public String nodeName() {
return nodeName;
}
+ public boolean canResolveRepartition() {
+ return keyChangingOperation || repartition != Repartition.NOT_REQUIRED;
Review Comment:
It indicates whether the node is able to determine if repartitioning is
needed. I renamed it to `canDetermineRepartition` for better clarity.
Also, the original `intent was keyChangingOperation || repartition !=
Repartition.BY_KEY`, but it was incorrectly modified during the refactoring
process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
