rajinisivaram commented on code in PR #20030:
URL: https://github.com/apache/kafka/pull/20030#discussion_r2165942934
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -1262,7 +1262,7 @@ public
CompletableFuture<List<DescribeGroupsResponseData.DescribedGroup>> descri
if (groupId == null) {
Review Comment:
Yes, that is correct. There are a few requests where empty group id is
supported, so we have this null check and an associated comment which mentions
that empty group id is supported. I think GroupCoordinatorServerTest includes
unit tests for all of those, but obviously no request tests since we can't get
there. Other requests use `isGroupIdNotEmpty`. Should we just leave this in to
maintain the same pattern for all requests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
