lucasbru commented on code in PR #20004:
URL: https://github.com/apache/kafka/pull/20004#discussion_r2161073348
##########
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##########
@@ -163,9 +163,10 @@ def restart_all_nodes_with(self, version):
self.processor3.stop_node(self.processor3.node)
# make sure the members have stopped
- self.wait_for_verification(self.processor1,
"SMOKE-TEST-CLIENT-CLOSED", self.processor1.STDOUT_FILE)
- self.wait_for_verification(self.processor2,
"SMOKE-TEST-CLIENT-CLOSED", self.processor2.STDOUT_FILE)
- self.wait_for_verification(self.processor3,
"SMOKE-TEST-CLIENT-CLOSED", self.processor3.STDOUT_FILE)
+ # some older versions crash on shutdown, so we allow crashes here.
+ self.wait_for_verification(self.processor1,
"SMOKE-TEST-CLIENT-(EXCEPTION|CLOSED)", self.processor1.STDOUT_FILE)
Review Comment:
I considered it, didn't want to introduce the complexity, but if you want to
have it I can add it. In the end, we aren't testing the old versions here, so I
think it's a valid approach to allow failures in what is not the system we are
testing, and which won't change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
