AndrewJSchofield commented on code in PR #19997:
URL: https://github.com/apache/kafka/pull/19997#discussion_r2156800313
##########
core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala:
##########
@@ -1367,55 +1367,50 @@ class ShareFetchAcknowledgeRequestTest(cluster:
ClusterInstance) extends GroupCo
sendFirstShareFetchRequest(memberId1, groupId, send, socket1)
initProducer()
- // Producing 10000 records to the topic created above
- produceData(topicIdPartition, 10000)
+ // Producing 1 records to the topic created above
+ produceData(topicIdPartition, 1)
- // Sending 3 share Fetch Requests with same groupId to the same
topicPartition but with different memberIds,
- // mocking the behaviour of multiple share consumers from the same share
group
+ // Sending a share Fetch Request
val metadata1: ShareRequestMetadata = new ShareRequestMetadata(memberId1,
ShareRequestMetadata.INITIAL_EPOCH)
val acknowledgementsMap1: Map[TopicIdPartition,
util.List[ShareFetchRequestData.AcknowledgementBatch]] = Map.empty
val shareFetchRequest1 = createShareFetchRequest(groupId, metadata1, send,
Seq.empty, acknowledgementsMap1, minBytes = 100, maxBytes = 1500)
+ val shareFetchResponse1 =
IntegrationTestUtils.sendAndReceive[ShareFetchResponse](shareFetchRequest1,
socket1)
+ val shareFetchResponseData1 = shareFetchResponse1.data()
+ val partitionData1 =
shareFetchResponseData1.responses().stream().findFirst().get().partitions().get(0)
+
+ // Producing 1 records to the topic created above
+ produceData(topicIdPartition, 1)
+ // Sending another share Fetch Request with same groupId to the same
topicPartition but with different memberId,
+ // mocking the behaviour of multiple share consumers from the same share
group
val metadata2: ShareRequestMetadata = new ShareRequestMetadata(memberId2,
ShareRequestMetadata.INITIAL_EPOCH)
val acknowledgementsMap2: Map[TopicIdPartition,
util.List[ShareFetchRequestData.AcknowledgementBatch]] = Map.empty
val shareFetchRequest2 = createShareFetchRequest(groupId, metadata2, send,
Seq.empty, acknowledgementsMap2, minBytes = 100, maxBytes = 1500)
+ val shareFetchResponse2 =
IntegrationTestUtils.sendAndReceive[ShareFetchResponse](shareFetchRequest2,
socket2)
+ val shareFetchResponseData2 = shareFetchResponse2.data()
+ val partitionData2 =
shareFetchResponseData2.responses().stream().findFirst().get().partitions().get(0)
+
+ // Producing 1 records to the topic created above
+ produceData(topicIdPartition, 1)
+ // Sending another share Fetch Request with same groupId to the same
topicPartition but with different memberId,
+ // mocking the behaviour of multiple share consumers from the same share
group
val metadata3: ShareRequestMetadata = new ShareRequestMetadata(memberId3,
ShareRequestMetadata.INITIAL_EPOCH)
val acknowledgementsMap3: Map[TopicIdPartition,
util.List[ShareFetchRequestData.AcknowledgementBatch]] = Map.empty
val shareFetchRequest3 = createShareFetchRequest(groupId, metadata3, send,
Seq.empty, acknowledgementsMap3, minBytes = 100, maxBytes = 1500)
-
- val shareFetchResponse1 =
IntegrationTestUtils.sendAndReceive[ShareFetchResponse](shareFetchRequest1,
socket1)
- val shareFetchResponse2 =
IntegrationTestUtils.sendAndReceive[ShareFetchResponse](shareFetchRequest2,
socket2)
val shareFetchResponse3 =
IntegrationTestUtils.sendAndReceive[ShareFetchResponse](shareFetchRequest3,
socket3)
-
-
- val shareFetchResponseData1 = shareFetchResponse1.data()
- assertEquals(Errors.NONE.code, shareFetchResponseData1.errorCode)
- assertEquals(1, shareFetchResponseData1.responses().size())
- assertEquals(topicId,
shareFetchResponseData1.responses().stream().findFirst().get().topicId())
- assertEquals(1,
shareFetchResponseData1.responses().stream().findFirst().get().partitions().size())
-
- val partitionData1 =
shareFetchResponseData1.responses().stream().findFirst().get().partitions().get(0)
-
- val shareFetchResponseData2 = shareFetchResponse2.data()
- assertEquals(Errors.NONE.code, shareFetchResponseData2.errorCode)
- assertEquals(1, shareFetchResponseData2.responses().size())
- assertEquals(topicId,
shareFetchResponseData2.responses().stream().findFirst().get().topicId())
- assertEquals(1,
shareFetchResponseData2.responses().stream().findFirst().get().partitions().size())
-
- val partitionData2 =
shareFetchResponseData2.responses().stream().findFirst().get().partitions().get(0)
-
val shareFetchResponseData3 = shareFetchResponse3.data()
- assertEquals(Errors.NONE.code, shareFetchResponseData3.errorCode)
- assertEquals(1, shareFetchResponseData3.responses().size())
- assertEquals(topicId,
shareFetchResponseData3.responses().stream().findFirst().get().topicId())
- assertEquals(1,
shareFetchResponseData3.responses().stream().findFirst().get().partitions().size())
-
val partitionData3 =
shareFetchResponseData3.responses().stream().findFirst().get().partitions().get(0)
- // There should be no common records between the 3 consumers as they are
part of the same group
- assertTrue(partitionData1.acquiredRecords().get(0).lastOffset() <
partitionData2.acquiredRecords().get(0).firstOffset())
- assertTrue(partitionData2.acquiredRecords().get(0).lastOffset() <
partitionData3.acquiredRecords().get(0).firstOffset())
+ // Each consumer should have received 1 record and any record should only
be consumed by 1 consumer
+ assertEquals(partitionData1.acquiredRecords().get(0).firstOffset(),
partitionData1.acquiredRecords().get(0).lastOffset())
+ assertEquals(partitionData1.acquiredRecords().get(0).firstOffset() , 0)
Review Comment:
nit: Redundant space before `,'.
##########
core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala:
##########
@@ -1367,55 +1367,50 @@ class ShareFetchAcknowledgeRequestTest(cluster:
ClusterInstance) extends GroupCo
sendFirstShareFetchRequest(memberId1, groupId, send, socket1)
initProducer()
- // Producing 10000 records to the topic created above
- produceData(topicIdPartition, 10000)
+ // Producing 1 records to the topic created above
Review Comment:
nit: 1 record, not records. There are a few other occurrences too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
