junrao commented on code in PR #19964:
URL: https://github.com/apache/kafka/pull/19964#discussion_r2154081661
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##########
@@ -855,7 +860,7 @@ private void sendProduceRequest(long now, int destination,
short acks, int timeo
if (batches.isEmpty())
return;
- final Map<TopicPartition, ProducerBatch> recordsByPartition = new
HashMap<>(batches.size());
+ final Map<TopicIdPartition, ProducerBatch> recordsByPartition = new
HashMap<>(batches.size());
Map<String, Uuid> topicIds = topicIdsForBatches(batches);
Review Comment:
It's true that `Sender::topicIdsForBatches` could return zero topicId in
rare cases. It seems that we could just pass along the mapping to zero topicId
when handling the produce response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
