ijuma commented on code in PR #19948:
URL: https://github.com/apache/kafka/pull/19948#discussion_r2150617216
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -1977,7 +1977,7 @@ public void
testOperationsBySubscribingConsumerWithDefaultGroupId(GroupProtocol
try {
newConsumer(groupProtocol, null, Optional.of(Boolean.TRUE));
fail("Expected an InvalidConfigurationException");
- } catch (InvalidConfigurationException e) {
+ } catch (InvalidConfigurationException swallow) {
Review Comment:
This is a bad pattern: `assertThrow` should be used instead. Same for the
other tests that were updated in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
