m1a2st commented on code in PR #18683:
URL: https://github.com/apache/kafka/pull/18683#discussion_r2148966769
##########
clients/src/main/java/org/apache/kafka/common/security/JaasUtils.java:
##########
@@ -16,9 +16,12 @@
*/
package org.apache.kafka.common.security;
+
public final class JaasUtils {
public static final String JAVA_LOGIN_CONFIG_PARAM =
"java.security.auth.login.config";
+ @Deprecated
public static final String DISALLOWED_LOGIN_MODULES_CONFIG =
"org.apache.kafka.disallowed.login.modules";
+ public static final String ALLOWED_LOGIN_MODULES_CONFIG =
"org.apache.kafka.allowed.login.modules";
public static final String DISALLOWED_LOGIN_MODULES_DEFAULT =
Review Comment:
We can add a version to the `@Deprecated` annotation to indicate when the
deprecation was introduced.
```
@Deprecated(since = "4.2")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
