mjsax commented on code in PR #19913:
URL: https://github.com/apache/kafka/pull/19913#discussion_r2146249146
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##########
@@ -555,21 +560,12 @@ public Set<String> makeReady(final Map<String,
InternalTopicConfig> topics) {
}
if (!topicsNotReady.isEmpty()) {
Review Comment:
It's always a good idea to split out partial PRs. If you wand to go this
way, we should work on such a partial PR first.
This PR does add the public `init()` methods and should "complete" the
feature. Merging this PR w/o all code in place is kinda "risky", as it puts us
into a weird partial state for the feature.
If we split out a PR that only adds the new config, and the check we just
discuss, it's would be much cleaner. For now, we can just move forward as you
already added the code in this PR, but if this PR gets too big, we could still
split out some code, merge the other PR first and rebase this PR later to
reduce it's size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
