OmniaGM commented on PR #15968:
URL: https://github.com/apache/kafka/pull/15968#issuecomment-2970470301
> I am wondering if we should include topicId in recordsByPartition in
sendProduceRequest(). This way, we don't need to check metadata for topicId
since it could change over time.
I have been looking into replacing this
```
String topicName = metadata.topicNames().getOrDefault(r.topicId(), r.name());
TopicPartition tp = new TopicPartition(topicName,
p.index());
```
which is used later to `batches.get(tp)` to the following
`TopicIdPartition` which I will be sending in `recordsByPartition`instead of
`TopicPartition`. The challenge am hitting now is the the response `r` in this
method already doesn't have topic name and only have topic id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
