cadonna commented on code in PR #19880:
URL: https://github.com/apache/kafka/pull/19880#discussion_r2139416341
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java:
##########
@@ -1230,17 +1219,6 @@ public boolean paranoidFileChecks() {
return columnFamilyOptions.paranoidFileChecks();
}
- @Override
- public Options setMaxWriteBufferNumberToMaintain(final int
maxWriteBufferNumberToMaintain) {
-
columnFamilyOptions.setMaxWriteBufferNumberToMaintain(maxWriteBufferNumberToMaintain);
- return this;
- }
-
- @Override
- public int maxWriteBufferNumberToMaintain() {
- return columnFamilyOptions.maxWriteBufferNumberToMaintain();
- }
-
Review Comment:
I find upgrading to 10.1.3 a good idea since it is the highest patch version
of the penultimate minor release. They are usually a good compromise between
robustness and improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
