mingyen066 opened a new pull request, #19942: URL: https://github.com/apache/kafka/pull/19942
Previously, the confirmation prompt for updating the PR body treated any input other than 'n' as approval, which could lead to unintended actions. With this change, the update will only proceed if the user enters 'y', 'Y', or presses Enter. For any other input, the operation is canceled and an Abort. message is printed. This makes the prompt behavior clearer and more predictable. Example: ``` ❯ ./committer-tools/reviewers.py Utility to help generate 'Reviewers' string for Pull Requests. Use Ctrl+D or Ctrl+C to exit Name or email (case insensitive): mingyen Possible matches (in order of most recent): [1] Ming-Yen Chung [email protected] (21) [2] Ming-Yen [email protected] (22) Make a selection: 1 Reviewers so far: [('Ming-Yen Chung', '[email protected]', 21)] Name or email (case insensitive): ^C Reviewers: Ming-Yen Chung <[email protected]> Pull Request (Ctrl+D or Ctrl+C to skip): 19936 New PR body will be: --- The original `props.setProperty(TopicConfig.SEGMENT_MS_CONFIG, config.logSegmentMillis.toString)` in the `KafkaMetadataLog` constructor was accidentally removed in #19371. Add a test to ensure this property is properly assigned. Reviewers: Ming-Yen Chung <[email protected]> --- Update the body of "KAFKA-19392: Fix metadata.log.segment.ms not being applied"? [Y/n] x Abort. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
