lianetm commented on code in PR #19814:
URL: https://github.com/apache/kafka/pull/19814#discussion_r2132881121
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##########
@@ -91,6 +92,13 @@ private enum SubscriptionType {
/* the list of topics the user has requested */
private Set<String> subscription;
+ /**
+ * Topic IDs received in an assignment from the coordinator when using the
Consumer rebalance protocol.
+ * This will be used to include assigned topic IDs in metadata requests
when the consumer
+ * does not know the topic names (ex. when the user subscribes to a RE2J
regex computed on the broker)
+ */
+ private Set<Uuid> assignedTopicIds;
+
Review Comment:
yeap, totally agree, just that I gave it a try and seemed like too much of a
refactoring on the `MembershipMgr` and `SubscriptionState` at this point (close
to the 4.1 cut), so went with the small fix to ensure it lands.
But totally agree that we could extract the assignment state that is now
into the subscription state for the classic consumer, and in the
subscriptionState and membershipMgr for the new consumer. Filing a jira and
I'll address that myself after this if that's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
