AndrewJSchofield commented on code in PR #19914:
URL: https://github.com/apache/kafka/pull/19914#discussion_r2132406509
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java:
##########
@@ -99,7 +99,7 @@ public void signalClose() {
*/
@Override
public NetworkClientDelegate.PollResult poll(final long currentTimeMs) {
- if (closing || this.coordinator != null)
Review Comment:
Well, we do need to be careful. There is also code to make sure that finding
a coordinator does not block the progress of closing. If you start a consumer
when there are no running brokers, close needs to complete promptly. If you
stop the brokers when a consumer has been running and then attempt a close, it
also needs to complete promptly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
