chia7712 commented on code in PR #19842:
URL: https://github.com/apache/kafka/pull/19842#discussion_r2129340580
##########
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##########
@@ -637,6 +637,12 @@ object KafkaMetadataLog extends Logging {
nodeId
)
+ // Print a warning if users have overridden the internal config
+ if (config.internalSegmentBytes() != null) {
+ metadataLog.error(s"Overriding
${MetadataLogConfig.INTERNAL_METADATA_LOG_SEGMENT_BYTES_CONFIG} is only
supported for testing. Setting " +
Review Comment:
we should print the warnings only if the segment size is configured to small
value. please consider comparing the value to
`METADATA_LOG_SEGMENT_BYTES_DEFAULT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]