aliehsaeedii commented on code in PR #19893: URL: https://github.com/apache/kafka/pull/19893#discussion_r2129169801
########## tools/src/test/java/org/apache/kafka/tools/streams/DeleteStreamsInternalTopicsTest.java: ########## @@ -0,0 +1,392 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.tools.streams; + +import org.apache.kafka.clients.admin.AdminClientConfig; +import org.apache.kafka.clients.consumer.ConsumerConfig; +import org.apache.kafka.common.GroupState; +import org.apache.kafka.common.serialization.Serdes; +import org.apache.kafka.common.serialization.StringSerializer; +import org.apache.kafka.common.utils.Exit; +import org.apache.kafka.coordinator.group.GroupCoordinatorConfig; +import org.apache.kafka.streams.GroupProtocol; +import org.apache.kafka.streams.KafkaStreams; +import org.apache.kafka.streams.KeyValueTimestamp; +import org.apache.kafka.streams.StreamsBuilder; +import org.apache.kafka.streams.StreamsConfig; +import org.apache.kafka.streams.integration.utils.EmbeddedKafkaCluster; +import org.apache.kafka.streams.integration.utils.IntegrationTestUtils; +import org.apache.kafka.streams.kstream.Consumed; +import org.apache.kafka.streams.kstream.KStream; +import org.apache.kafka.streams.kstream.KTable; +import org.apache.kafka.streams.kstream.Materialized; +import org.apache.kafka.test.TestUtils; +import org.apache.kafka.tools.ToolsTestUtils; + +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Tag; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.Timeout; + +import java.time.Duration; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.Locale; +import java.util.Map; +import java.util.Objects; +import java.util.Optional; +import java.util.Properties; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.concurrent.atomic.AtomicInteger; + +import joptsimple.OptionException; + +import static org.apache.kafka.common.GroupState.EMPTY; +import static org.junit.jupiter.api.Assertions.assertNotEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +@Timeout(600) +@Tag("integration") +public class DeleteStreamsInternalTopicsTest { + private static final String APP_ID_PREFIX = "delete-internal-topics-test-"; + private static final String INPUT_TOPIC_PREFIX = "input-topic-"; + private static final int RECORD_TOTAL = 10; + public static EmbeddedKafkaCluster cluster; + private static String bootstrapServers; + + @BeforeAll + public static void startCluster() { + final Properties props = new Properties(); + props.setProperty(GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, "classic,consumer,streams"); + cluster = new EmbeddedKafkaCluster(2, props); + cluster.start(); + + bootstrapServers = cluster.bootstrapServers(); + } + + @AfterAll + public static void closeCluster() { + cluster.stop(); + } + + @Test + public void testDeleteWithUnrecognizedOption() { + final String[] args = new String[]{"--unrecognized-option", "--bootstrap-server", bootstrapServers, "--delete", + "--internal-topic", "foo", "--group", "bar"}; + assertThrows(OptionException.class, () -> getStreamsGroupService(args)); + } + + @Test + public void testDeleteWithoutGroupOption() { + final String[] args = new String[]{"--bootstrap-server", bootstrapServers, "--delete", "--internal-topic", "foo"}; + AtomicBoolean exited = new AtomicBoolean(false); + Exit.setExitProcedure(((statusCode, message) -> { + assertNotEquals(0, statusCode); + assertTrue(message.contains("Option [delete] takes the option [group]")); + exited.set(true); + })); + try { + getStreamsGroupService(args); + } finally { + assertTrue(exited.get()); + } + } + + @Test + public void testDeleteWithoutInternalTopicOption() { + final String[] args = new String[]{"--bootstrap-server", bootstrapServers, "--delete", "--group", "foo"}; + AtomicBoolean exited = new AtomicBoolean(false); + Exit.setExitProcedure(((statusCode, message) -> { + assertNotEquals(0, statusCode); + assertTrue(message.contains("Option [delete] takes one of these options: [internal-topic], [all-internal-topics]")); + exited.set(true); + })); + try { + getStreamsGroupService(args); + } finally { + assertTrue(exited.get()); + } + } + + @Test + public void testDeleteInternalTopicNotExistingGroup() { + String[] args = new String[]{"--bootstrap-server", bootstrapServers, "--delete", "--internal-topic", "foo", "--group", "bar"}; + StreamsGroupCommand.StreamsGroupService service = getStreamsGroupService(args); + String output = ToolsTestUtils.grabConsoleOutput(service::deleteInternalTopics); + assertTrue(output.contains("Group 'bar' does not exist or is not a streams group.")); Review Comment: I dont know what you mean. if internal topic is missing then it would be `--delete --group g1`, which means delete the group. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
