AndrewJSchofield commented on code in PR #19886:
URL: https://github.com/apache/kafka/pull/19886#discussion_r2123477816
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -411,6 +429,7 @@ public void onFailure(final long currentTimeMs, final
RuntimeException e) {
if (e != null) {
this.future.completeExceptionally(e);
} else {
+ System.out.println("Disconnect onFailure");
Review Comment:
I think you meant to remove this too.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -144,6 +145,17 @@ public void tryConnect(Node node) {
* @param currentTimeMs current time
*/
public void poll(final long timeoutMs, final long currentTimeMs) {
+ poll(timeoutMs, currentTimeMs, false);
+ }
+
+ /**
+ * Returns the responses of the sent requests. This method will try to
send the unsent requests, poll for responses,
+ * and check the disconnected nodes.
+ *
+ * @param timeoutMs timeout time
+ * @param currentTimeMs current time
+ */
Review Comment:
nit: Missed `onClose` from javadoc.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -184,6 +196,7 @@ private void trySend(final long currentTimeMs) {
Iterator<UnsentRequest> iterator = unsentRequests.iterator();
while (iterator.hasNext()) {
UnsentRequest unsent = iterator.next();
+ System.out.println("Processing unsent request: " + unsent);
Review Comment:
I think you meant to remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
