kamalcph commented on code in PR #19853:
URL: https://github.com/apache/kafka/pull/19853#discussion_r2122823725
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemotePartitionMetadataEventHandler.java:
##########
@@ -42,12 +42,6 @@ public void handleRemoteLogMetadata(RemoteLogMetadata
remoteLogMetadata) {
protected abstract void
handleRemotePartitionDeleteMetadata(RemotePartitionDeleteMetadata
remotePartitionDeleteMetadata);
- public void syncLogMetadataSnapshot(TopicIdPartition topicIdPartition,
Review Comment:
KAFKA-16454 was filed to snapshot the __remote_log_metadata topic for faster
restarts, so the `syncLogMetadataSnapshot` and
`RemoteLogSegmentMetadataSnapshot.java` was not removed.
> is it ok to remove it?
The unused `syncLogMetadataSnapshot` method can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
