jsancio commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2116216631
##########
raft/src/test/java/org/apache/kafka/raft/RequestManagerTest.java:
##########
@@ -256,25 +398,25 @@ public void testAnyInflightRequestWithAnyRequest() {
random
);
- assertFalse(cache.hasAnyInflightRequest(time.milliseconds()));
Review Comment:
You can think of tests as a form of documentation. All of the KRaft RPCs
that are not FETCH and FETCH_SNAPSHOT behave in a certain way while FETCH and
FETCH_SNAPSHOT behave in a different way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
