jsancio commented on code in PR #19800:
URL: https://github.com/apache/kafka/pull/19800#discussion_r2113736930
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -264,13 +267,15 @@ public short partitionRecordVersion() {
}
public short fetchRequestVersion() {
- if (this.isAtLeast(IBP_3_9_IV0)) {
+ if (isAtLeast(IBP_4_1_IV1)) {
+ return 18;
Review Comment:
> can you remind me why the default value of the new HW field would ever be
used?
The default value is what the receiver of the FETCH request sees if the HWM
tagged field is not specified.
> if the fetch request version to use is dictated by MV, then shouldn't all
nodes agree on which fetch request/response version to use?
Yes. If the finalized MV is IBP_4_1_IV1, all of the brokers agree to send
fetch version 18.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
