sjhajharia commented on code in PR #19804:
URL: https://github.com/apache/kafka/pull/19804#discussion_r2113187704
##########
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##########
@@ -364,7 +364,7 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
def changeClientIdConfig(sanitizedClientId: String, configs: Properties):
Unit = {
Using.resource(createAdminClient(brokers, listenerName)) {
admin => {
- admin.alterClientQuotas(Collections.singleton(
+ admin.alterClientQuotas(util.Set.of(
new ClientQuotaAlteration(
new ClientQuotaEntity(Map(ClientQuotaEntity.CLIENT_ID -> (if
(sanitizedClientId == "<default>") null else sanitizedClientId)).asJava),
Review Comment:
No. We can't use that here because of the if block. In case of "<default>'
it ends up with null with Map.of wouldn't allow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
