m1a2st commented on code in PR #19669:
URL: https://github.com/apache/kafka/pull/19669#discussion_r2112188223
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -913,16 +914,16 @@ public void
verifyNoCoordinatorLookupForManualAssignmentWithSeek(GroupProtocol g
consumer.assign(singleton(tp0));
consumer.seekToBeginning(singleton(tp0));
- // there shouldn't be any need to lookup the coordinator or fetch
committed offsets.
- // we just lookup the starting position and send the record fetch.
+ // there shouldn't be any need to look up the coordinator or fetch
committed offsets.
+ // we just look up the starting position and send the record fetch.
client.prepareResponse(listOffsetsResponse(Collections.singletonMap(tp0, 50L)));
client.prepareResponse(fetchResponse(tp0, 50L, 5));
ConsumerRecords<String, String> records = (ConsumerRecords<String,
String>) consumer.poll(Duration.ofMillis(1));
assertEquals(5, records.count());
assertEquals(55L, consumer.position(tp0));
- assertEquals(records.nextOffsets().size(), 1);
- assertEquals(records.nextOffsets().get(tp0), new
OffsetAndMetadata(55L, Optional.empty(), ""));
+ assertEquals(1, records.nextOffsets().size());
+ assertEquals(new OffsetAndMetadata(55L, Optional.empty(), ""),
records.nextOffsets().get(tp0));
Review Comment:
This one is still missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
