lucasbru commented on code in PR #19813:
URL: https://github.com/apache/kafka/pull/19813#discussion_r2107119425
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##########
@@ -346,18 +346,18 @@ private void optimizeTopology(final Properties props) {
(String)
props.get(StreamsConfig.TOPOLOGY_OPTIMIZATION_CONFIG));
}
if
(optimizationConfigs.contains(StreamsConfig.REUSE_KTABLE_SOURCE_TOPICS)) {
- LOG.debug("Optimizing the Kafka Streams graph for ktable source
nodes");
+ LOG.debug("Optimizing the Kafka streams graph for ktable source
nodes");
reuseKTableSourceTopics();
}
if
(optimizationConfigs.contains(StreamsConfig.MERGE_REPARTITION_TOPICS)) {
- LOG.debug("Optimizing the Kafka Streams graph for repartition
nodes");
+ LOG.debug("Optimizing the Kafka streams graph for repartition
nodes");
mergeRepartitionTopics();
}
if
(optimizationConfigs.contains(StreamsConfig.SINGLE_STORE_SELF_JOIN)) {
- LOG.debug("Optimizing the Kafka Streams graph for self-joins");
+ LOG.debug("Optimizing the Kafka streams graph for self-joins");
rewriteSingleStoreSelfJoin(root, new IdentityHashMap<>());
}
- LOG.debug("Optimizing the Kafka Streams graph for null-key records");
+ LOG.debug("Optimizing the Kafka streams graph for null-key records");
Review Comment:
I think even if we want to use "streams" in lower case, we should capitalize
"Kafka Streams" IMHO.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -16021,7 +16021,7 @@ public void
testStreamsGroupMemberRequestingShutdownApplication() {
.setShutdownApplication(true)
);
- String statusDetail = String.format("Streams group member %s
encountered a fatal error and requested a shutdown for the entire
application.", memberId1);
+ String statusDetail = String.format("streams group member %s
encountered a fatal error and requested a shutdown for the entire
application.", memberId1);
Review Comment:
we shouldn't replace it at the beginning of the line
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2010,7 +2010,7 @@ private CoordinatorResult<StreamsGroupHeartbeatResult,
CoordinatorRecord> stream
new Status()
.setStatusCode(StreamsGroupHeartbeatResponse.Status.SHUTDOWN_APPLICATION.code())
.setStatusDetail(
- String.format("Streams group member %s encountered a fatal
error and requested a shutdown for the entire application.",
+ String.format("streams group member %s encountered a fatal
error and requested a shutdown for the entire application.",
Review Comment:
we shouldn't replace it at the beginning of the line
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -880,7 +880,7 @@ StreamsGroup getStreamsGroupOrThrow(
Group group = groups.get(groupId);
if (group == null) {
- throw new GroupIdNotFoundException(String.format("Streams group %s
not found.", groupId));
+ throw new GroupIdNotFoundException(String.format("streams group %s
not found.", groupId));
Review Comment:
we shouldn't replace it at the beginning of the line
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -236,7 +236,7 @@ public class GroupCoordinatorConfig {
public static final String SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DOC =
"The maximum heartbeat interval for share group members.";
///
- /// Streams group configs
+ /// streams group configs
Review Comment:
we shouldn't replace it at the beginning of the line
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -466,7 +466,7 @@ public GroupCoordinatorConfig(AbstractConfig config) {
require(shareGroupHeartbeatIntervalMs < shareGroupSessionTimeoutMs,
String.format("%s must be less than %s",
SHARE_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG,
SHARE_GROUP_SESSION_TIMEOUT_MS_CONFIG));
- // Streams group configs validation.
+ // streams group configs validation.
Review Comment:
we shouldn't replace it at the beginning of the line
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -16105,7 +16105,7 @@ public void
testStreamsGroupMemberRequestingShutdownApplicationUponLeaving() {
.setShutdownApplication(true)
);
- String statusDetail = String.format("Streams group member %s
encountered a fatal error and requested a shutdown for the entire
application.", memberId1);
+ String statusDetail = String.format("streams group member %s
encountered a fatal error and requested a shutdown for the entire
application.", memberId1);
Review Comment:
we shouldn't replace it at the beginning of the line
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1022,7 +1022,7 @@ private StreamsGroup
getOrMaybeCreatePersistedStreamsGroup(
Group group = groups.get(groupId);
if (group == null && !createIfNotExists) {
- throw new GroupIdNotFoundException(String.format("Streams group %s
not found.", groupId));
+ throw new GroupIdNotFoundException(String.format("streams group %s
not found.", groupId));
Review Comment:
we shouldn't replace it at the beginning of the line
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -15357,7 +15357,7 @@ public void testUnknownStreamsGroupId() {
.setActiveTasks(List.of())
.setStandbyTasks(List.of())
.setWarmupTasks(List.of())));
- assertEquals("Streams group fooup not found.", e.getMessage());
+ assertEquals("streams group fooup not found.", e.getMessage());
Review Comment:
we shouldn't replace it at the beginning of the line
##########
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##########
@@ -345,9 +345,9 @@ Map<TopicPartition, OffsetAndMetadata>
getCommittedOffsets(String groupId) {
*/
private static void maybePrintEmptyGroupState(String group, GroupState
state) {
if (state == GroupState.DEAD) {
- printError("Streams group '" + group + "' does not exist.",
Optional.empty());
+ printError("streams group '" + group + "' does not exist.",
Optional.empty());
Review Comment:
we shouldn't replace it at the beginning of the line
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -367,7 +367,7 @@ public class GroupCoordinatorConfig {
private final int shareGroupHeartbeatIntervalMs;
private final int shareGroupMinHeartbeatIntervalMs;
private final int shareGroupMaxHeartbeatIntervalMs;
- // Streams group configurations
+ // streams group configurations
Review Comment:
we shouldn't replace it at the beginning of the line
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -415,7 +415,7 @@ public GroupCoordinatorConfig(AbstractConfig config) {
this.shareGroupMinHeartbeatIntervalMs =
config.getInt(GroupCoordinatorConfig.SHARE_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG);
this.shareGroupMaxHeartbeatIntervalMs =
config.getInt(GroupCoordinatorConfig.SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG);
this.shareGroupMaxSize =
config.getInt(GroupCoordinatorConfig.SHARE_GROUP_MAX_SIZE_CONFIG);
- // Streams group configurations
+ // streams group configurations
Review Comment:
we shouldn't replace it at the beginning of the line
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -318,7 +318,7 @@ public class GroupCoordinatorConfig {
.define(SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG, INT,
SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DEFAULT, atLeast(1), MEDIUM,
SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DOC)
.define(SHARE_GROUP_MAX_SIZE_CONFIG, INT,
SHARE_GROUP_MAX_SIZE_DEFAULT, between(1, 1000), MEDIUM,
SHARE_GROUP_MAX_SIZE_DOC)
- // Streams group configs
+ // streams group configs
Review Comment:
we shouldn't replace it at the beginning of the line
##########
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##########
@@ -1030,7 +1030,7 @@ class KafkaConfigTest {
case ShareGroupConfig.SHARE_GROUP_MAX_SHARE_SESSIONS_CONFIG =>
assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
case ShareGroupConfig.SHARE_GROUP_PERSISTER_CLASS_NAME_CONFIG =>
//ignore string
- /** Streams groups configs */
+ /** streams groups configs */
Review Comment:
we shouldn't replace it at the beginning of the line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
