dajac commented on code in PR #19790:
URL: https://github.com/apache/kafka/pull/19790#discussion_r2106896835
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -2485,8 +2485,6 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
// Test offset deletion while consuming
val offsetDeleteResult =
client.deleteConsumerGroupOffsets(testGroupId, util.Set.of(tp1, tp2))
- // Top level error will equal to the first partition level error
- assertFutureThrows(classOf[GroupSubscribedToTopicException],
offsetDeleteResult.all())
Review Comment:
It seems that we can revert this change now.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroupTest.java:
##########
@@ -1576,6 +1581,7 @@ public void testFromClassicGroup() {
assertEquals(expectedConsumerGroup.groupEpoch(),
consumerGroup.groupEpoch());
assertEquals(expectedConsumerGroup.state(), consumerGroup.state());
assertEquals(expectedConsumerGroup.preferredServerAssignor(),
consumerGroup.preferredServerAssignor());
+ assertEquals(Map.copyOf(expectedConsumerGroup.subscriptionMetadata()),
Map.copyOf(consumerGroup.subscriptionMetadata()));
Review Comment:
Is `Map.copyOf` really necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
