chia7712 commented on code in PR #19687:
URL: https://github.com/apache/kafka/pull/19687#discussion_r2100995473
##########
core/src/main/scala/kafka/server/ConfigHelper.scala:
##########
@@ -130,7 +131,7 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
else if (resourceNameToBrokerId(resource.resourceName) !=
config.brokerId)
throw new InvalidRequestException(s"Unexpected broker id,
expected ${config.brokerId} but received ${resource.resourceName}")
else
- createResponseConfig(LoggingController.loggers,
+ createResponseConfig(LoggingController.loggers.asScala,
Review Comment:
Or we can refactor `createResponseConfig` to avoid creating extra collection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
