jsancio commented on code in PR #19745:
URL: https://github.com/apache/kafka/pull/19745#discussion_r2098863446
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -411,7 +411,7 @@ class BrokerServer(
config,
"heartbeat",
s"broker-${config.nodeId}-",
- config.brokerSessionTimeoutMs / 2 // KAFKA-14392
+ config.brokerHeartbeatIntervalMs
Review Comment:
Can you file a Jira for both of these?
> It's a bit tricky to add validations like that since it may cause
currently working setups to not start up any more. I do think we should add a
WARN log or something if the heartbeat configuration doesn't make sense. I
think that also belongs in a follow-on PR.
That's an interesting observation. Is it better for the user to have
previously valid config now be invalid? Or have a cluster that causes brokers
to fence incorrectly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
