dajac commented on code in PR #19611:
URL: https://github.com/apache/kafka/pull/19611#discussion_r2094976739
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java:
##########
@@ -112,7 +112,7 @@ public Set<Integer> assignablePartitions(Uuid topicId) {
}
if (topicPartitionAllowedMap.isEmpty()) {
- return Set.copyOf(topic.partitions().keySet());
+ return topic.partitions().keySet();
Review Comment:
nit: I would use Collections.unmodifiableSet to ensure that it cannot be
mutated by the caller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
