dajac commented on code in PR #19642:
URL: https://github.com/apache/kafka/pull/19642#discussion_r2077881699
##########
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java:
##########
@@ -60,221 +55,126 @@
public class OffsetFetchResponse extends AbstractResponse {
public static final long INVALID_OFFSET = -1L;
public static final String NO_METADATA = "";
- public static final PartitionData UNKNOWN_PARTITION = new
PartitionData(INVALID_OFFSET,
-
Optional.empty(),
-
NO_METADATA,
-
Errors.UNKNOWN_TOPIC_OR_PARTITION);
- public static final PartitionData UNAUTHORIZED_PARTITION = new
PartitionData(INVALID_OFFSET,
-
Optional.empty(),
-
NO_METADATA,
-
Errors.TOPIC_AUTHORIZATION_FAILED);
+
private static final List<Errors> PARTITION_ERRORS = Arrays.asList(
- Errors.UNKNOWN_TOPIC_OR_PARTITION, Errors.TOPIC_AUTHORIZATION_FAILED);
+ Errors.UNKNOWN_TOPIC_OR_PARTITION,
+ Errors.TOPIC_AUTHORIZATION_FAILED,
+ Errors.UNSTABLE_OFFSET_COMMIT
Review Comment:
Not really. I was debating whether we should be exhaustive here and list all
the partition errors or not. Let me remove it and add a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
