chirag-wadhwa5 commented on code in PR #19640:
URL: https://github.com/apache/kafka/pull/19640#discussion_r2075342091
##########
core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala:
##########
@@ -59,11 +59,15 @@ class ShareFetchAcknowledgeRequestTest(cluster:
ClusterInstance) extends GroupCo
new TopicIdPartition(Uuid.randomUuid(), new TopicPartition("topic1", 1))
)
+ val socket: Socket = createSocket()
+
val shareFetchRequest = createShareFetchRequest(groupId, metadata, send,
Seq.empty, Map.empty)
- val shareFetchResponse =
connectAndReceiveWithoutClosingSocket[ShareFetchResponse](shareFetchRequest)
+ val shareFetchResponse =
sendAndReceiveFromExistingSocket[ShareFetchResponse](shareFetchRequest, socket)
assertEquals(Errors.UNSUPPORTED_VERSION.code,
shareFetchResponse.data.errorCode)
assertEquals(0, shareFetchResponse.data.acquisitionLockTimeoutMs)
+
+ socket.close()
Review Comment:
Thanks for the review. I have now updated the tests to include a ListBuffer
that stores any new sockets that are created. And in the tearDown, the list is
iterated to close all the sockets that are still open
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
