AndrewJSchofield commented on code in PR #19647:
URL: https://github.com/apache/kafka/pull/19647#discussion_r2075050668
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java:
##########
@@ -1017,8 +1017,12 @@ private void maybeThrowInvalidGroupIdException() {
* <p>
* If the acknowledgement commit callback throws an exception, this method
will throw an exception.
*/
- private void handleCompletedAcknowledgements() {
- processBackgroundEvents();
+ private void handleCompletedAcknowledgements(boolean onClose) {
+ // If the user gets any fatal errors, they will get these exceptions
in the background queue.
+ // While closing, we ignore these exceptions so that the consumers
close successfully.
+ processBackgroundEvents(onClose ? e -> (e instanceof
GroupAuthorizationException
Review Comment:
This is an extremely specific list of exceptions to ignore. I wonder why
precisely these three make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
